Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Hot Module Reloading (HMR) / WebSocket support to the proxy layer by ensuring upgrade requests are proxied correctly and by aligning Host/Origin handling for upstream dev servers.
Changes:
- Bypass the HTML-injection response recorder for WebSocket upgrade requests to preserve
http.Hijackerbehavior. - Clone request headers (avoid mutating/sharing the original header map) and set upstream
Host; rewriteOriginfor same-host WebSocket requests to match the selected upstream. - Add Go tests covering WebSocket upgrade pass-through, HTML asset injection, and WebSocket routing to the correct origin.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| proxy/handler.go | Adds WebSocket upgrade detection, skips recorder path for upgrades, clones headers, sets Host, and rewrites Origin for WS requests. |
| proxy/handler_test.go | Adds regression tests validating WS upgrade behavior, injection on HTML responses, and correct origin routing for WS/HMR. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+11
to
+12
| "sync/atomic" | ||
| "strings" |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.